Add a patch in rviz_ogre_vendor to build with clang on macOS #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
ahcorde
requested changes
Jul 2, 2025
| #include <stdexcept> | ||
|
|
||
| +#if (OGRE_PLATFORM == OGRE_PLATFORM_APPLE || OGRE_PLATFORM == OGRE_PLATFORM_APPLE_IOS) && __clang_major__ >= 15 | ||
| +#include <string> |
| + static bool lt(const char_type& a, const char_type& b) { return a < b; } | ||
| + | ||
| + static int compare(const char_type* s1, const char_type* s2, size_t n) { | ||
| + for (size_t i = 0; i < n; ++i) { |
| +#endif | ||
| + | ||
| +#if (OGRE_PLATFORM == OGRE_PLATFORM_APPLE || OGRE_PLATFORM == OGRE_PLATFORM_APPLE_IOS) && __clang_major__ >= 15 | ||
| +#include <string> |
| +} | ||
| +#endif | ||
| + | ||
| +#if (OGRE_PLATFORM == OGRE_PLATFORM_APPLE || OGRE_PLATFORM == OGRE_PLATFORM_APPLE_IOS) && __clang_major__ >= 15 |
There was a problem hiding this comment.
the #if is the same as the upper one. Is this duplicated ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tried building
rviz_ogre_vendorand MacOS 15 (Sequoia) with XCode 16.x and build fails as the newer versions of (apple)clangon macOS is does not provide default implementations ofstd::char_traitsfor non-standard character types like unsigned short and unsigned int.The PR adds a patch that provides explicit specializations for std::char_traits and std::char_traits. It defines all the necessary types and static member functions (like compare, length, copy, assign, etc.) that std::basic_string needs to operate on these character types.
Is this user-facing behavior change?
Yes
Did you use Generative AI?
Yes, patch file generated using Gemini Code Assist extension in VSCode.
Additional Information